[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

[Renato Golin via Phabricator via cfe-commits]

rengolin added a comment.

I just applied this to a recent HEAD and got a few warnings. Please make sure there are no new warnings on changes / new files.

  /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/CSKYInstrFormats.td:658:62: warning: unused template argument: R_Z_2:pattern
  class R_Z_2<bits<6> sop, bits<5> pcode, string op, list<dag> pattern>
                                                               ^



  In file included from /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/CSKYFrameLowering.cpp:14:
  /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/CSKYMachineFunctionInfo.h:21:20: warning: private field 'MF' is not used [-Wunused-private-field]
    MachineFunction &MF;
                     ^



  /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/CSKYInstrInfo.cpp:480:24: warning: unused variable 'MRI' [-Wunused-variable]
    MachineRegisterInfo &MRI = MBB.getParent()->getRegInfo();
                         ^



  /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/Disassembler/CSKYDisassembler.cpp:169:21: warning: unused function 'DecodesFPR128RegisterClass' [-Wunused-function]
  static DecodeStatus DecodesFPR128RegisterClass(MCInst &Inst, uint64_t RegNo,
                      ^
  /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/Disassembler/CSKYDisassembler.cpp:199:21: warning: unused function 'DecodeGPRSPRegisterClass' [-Wunused-function]
  static DecodeStatus DecodeGPRSPRegisterClass(MCInst &Inst, uint64_t RegNo,
                      ^
  /home/rengolin/devel/llvm-project/llvm/lib/Target/CSKY/Disassembler/CSKYDisassembler.cpp:36:16: warning: private field 'inDataRegion' is not used [-Wunused-private-field]
    mutable bool inDataRegion = false;
                 ^

etc.

There is also a test error:

  ******************** TEST 'Clang :: Driver/csky-toolchain.c' FAILED ********************
  ...
  /home/rengolin/devel/llvm-project/clang/test/Driver/csky-toolchain.c:16:24: error: C-CSKY-LINUX-MULTI: expected string not found in input
  // C-CSKY-LINUX-MULTI: "{{.*}}/Inputs/multilib_csky_linux_sdk/lib/gcc/csky-linux-gnuabiv2/6.3.0/../../..{{/|\\\\}}..{{/|\\\\}}csky-linux-gnuabiv2/bin{{/|\\\\}}ld"
                         ^

I'm guessing this is the path of a local sysroot you have on your machine?

If possible, try to get a new environment (container, VM, alternative machine) and make sure a clean build still passes the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121445/new/

https://reviews.llvm.org/D121445