[PATCH] D122712: Make test case warning more specific for pattern match

Ranjeet Singh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 06:04:16 PDT 2022


rs added a comment.

In D122712#3416238 <https://reviews.llvm.org/D122712#3416238>, @benshi001 wrote:

> I do not like this change, since
>
> 1. actually there may be many kinds of warnings emitted by the clang-driver-avr depending on different options, and this single line `// NOWARN-NOT: warning:` means non of these possible warnings will be emitted.
>
> 2. we may add/delete/modify warnings in the future, so we should not make it specific .

ok fair enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122712/new/

https://reviews.llvm.org/D122712



More information about the cfe-commits mailing list