[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

[Andrew via Phabricator via cfe-commits]

browneee added inline comments.


================
Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:2515-2540
 SANITIZER_INTERFACE_WEAK_DEF(void, __dfsw___sanitizer_cov_trace_cmp, void) {}
 SANITIZER_INTERFACE_WEAK_DEF(void, __dfsw___sanitizer_cov_trace_cmp1, void) {}
 SANITIZER_INTERFACE_WEAK_DEF(void, __dfsw___sanitizer_cov_trace_cmp2, void) {}
 SANITIZER_INTERFACE_WEAK_DEF(void, __dfsw___sanitizer_cov_trace_cmp4, void) {}
 SANITIZER_INTERFACE_WEAK_DEF(void, __dfsw___sanitizer_cov_trace_cmp8, void) {}
+SANITIZER_INTERFACE_WEAK_DEF(void, __dfsw___sanitizer_cov_trace_cmp_fp2,
+                             void) {}
----------------
This (including the existing code) [wouldn't](https://github.com/llvm/llvm-project/blob/8f66f1371981bda1af1ca43d505e1bc5836b3e36/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp#L2802
) work if [dfsan-track-origins](https://github.com/llvm/llvm-project/blob/8f66f1371981bda1af1ca43d505e1bc5836b3e36/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp#L235)=1.

I guess this is something no one has tried, so probably not important? I'm also unsure where dfsan + sancov is used?


================
Comment at: compiler-rt/lib/fuzzer/dataflow/DataFlowCallbacks.cpp:92
 
 } // extern "C"
----------------
Note that many of the lib/fuzzer/dataflow/ [tests were disabled](https://github.com/llvm/llvm-project/commit/070556237e29e8a804fbec1d416d431239384ab0), as no one was using this... and I think they are still disabled.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119621/new/

https://reviews.llvm.org/D119621