[PATCH] D122679: [OpenMP] Use offload bundler when outputting textual formats with new driver

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 29 13:20:33 PDT 2022


jhuber6 added inline comments.


================
Comment at: clang/test/Driver/openmp-offload-gpu.c:350
+
+// RUN:   %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -Xopenmp-target=nvptx64-nvida-cuda -march=sm_70 \
+// RUN:          --libomptarget-nvptx-bc-path=%S/Inputs/libomptarget/libomptarget-new-nvptx-test.bc \
----------------
MaskRay wrote:
> Delete excessive indentation
> 
> Generally indenting the continuation lines by 2 column is sufficient.
All the other lines are formatted like this in this file so I was just keeping it consistent. I could make a separate patch to clean it up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122679/new/

https://reviews.llvm.org/D122679



More information about the cfe-commits mailing list