[PATCH] D122087: Add HLSL Language Option and Preprocessor

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 29 10:45:24 PDT 2022


beanz added inline comments.


================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401
+    // The current shader stage itself
+    uint32_t StageInteger = StageInteger =
+        (uint32_t)TI.getTriple().getEnvironment() -
----------------
erichkeane wrote:
> Why does this do a double-assign here?  Is th ere supposed to be a 2nd variable here?  Otherwise this is likely not particularly well-defined behavior.
I must have screwed this up in rebating one of the patches. Will fix ASAP.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122087/new/

https://reviews.llvm.org/D122087



More information about the cfe-commits mailing list