[PATCH] D122662: [Clang][CodeGen] Add constant array support for __builtin_dump_sturct, and beautify dump format

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D122662#3414319 <https://reviews.llvm.org/D122662#3414319>, @yihanaa wrote:

> In D122662#3414284 <https://reviews.llvm.org/D122662#3414284>, @erichkeane wrote:
>
>> I'd also suggest splitting into the '3' things that you're trying to accomplish above.  The CGBuiltin.cpp code has way too much going on to reasonably review.
>
>
>
> In D122662#3414284 <https://reviews.llvm.org/D122662#3414284>, @erichkeane wrote:
>
>> I'd also suggest splitting into the '3' things that you're trying to accomplish above.  The CGBuiltin.cpp code has way too much going on to reasonably review.
>
> Maybe I should split the third thing into another separate patch, the first thing needs to modify the indent when adding constant array support, that is the third thing (modify the indent), what do you think?

I would suggest piling them from #3, to #2 to #1.  That is: "Change the anonymous printing" in the first, add the 'sub-element-tabbing' in 2nd, and 'add constant array support' in 3rd.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122662/new/

https://reviews.llvm.org/D122662