[PATCH] D122662: [Clang][CodeGen] Add constant array support for __builtin_dump_sturct, and beautify dump format
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 29 08:54:32 PDT 2022
erichkeane added a comment.
This looks to be quite the large patch, can you split this up into individual patches? It isn't clear to me what all is going on everywhere.
================
Comment at: clang/docs/ReleaseNotes.rst:93
and `51641 <https://github.com/llvm/llvm-project/issues/51641>`_.
+- The builtin function __builtin_dump_struct would crash clang when the target
+ struct have bitfield. Now it fixed.
----------------
What is this from/for? Is this left over from a previous patch?
================
Comment at: clang/docs/ReleaseNotes.rst:113
-------------------------------------------------
-- The builtin function __builtin_dump_struct would crash clang when the target
- struct have bitfield. Now it fixed, and __builtin_dump_struct support dump
- the bitwidth of bitfields.
- This fixes `Issue 54462 <https://github.com/llvm/llvm-project/issues/54462>`_.
+- The builtin function __builtin_dump_struct support dump constant array and the
+ bitwidth of bitfields in a struct.
----------------
"now supports dumping constant arrays" perhaps?
================
Comment at: clang/docs/ReleaseNotes.rst:114
+- The builtin function __builtin_dump_struct support dump constant array and the
+ bitwidth of bitfields in a struct.
+
----------------
This should probably be a different entry than the bitfield one.
================
Comment at: clang/docs/ReleaseNotes.rst:155
-- Improve __builtin_dump_struct:
-
----------------
Probably want a separate patch to fix these.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122662/new/
https://reviews.llvm.org/D122662
More information about the cfe-commits
mailing list