[PATCH] D122524: [Driver][AVR] Emit proper warnings for different options
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 28 21:03:05 PDT 2022
MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:477
if (!LinkStdlib)
D.Diag(diag::warn_drv_avr_stdlib_not_linked);
----------------
benshi001 wrote:
> We should not merge the above two `if`, due to this check.
>
> So I will keep my orginal form when committing.
OK. If we decide that empty -mpu will report a warning, reporting an additional warn_drv_avr_stdlib_not_linked may or may not be necessary, but I'm happy to defer that decision to you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122524/new/
https://reviews.llvm.org/D122524
More information about the cfe-commits
mailing list