[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

Mon Mar 28 19:24:43 PDT 2022

pow2clk added a comment.

Looks good. I made a comment about the CS 4.0 thing, but that can be addressed when more thorough examination of the requested shader models comes around.

================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6857
+  uint32_t ThreadMax = 1024;
+  if (SMVersion.getMajor() <= 4) {
+    ZMax = 1;
----------------
As we discussed, compute shaders didn't actually exist pre-4.0 and I don't know that we'll ever seek to do anything with a 4.0 shader model except convert it to a higher version and issue a notification, but that handling is clearly not the intent of this change. So it's fine with me. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122627/new/

https://reviews.llvm.org/D122627