[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 28 13:49:16 PDT 2022


dang added inline comments.


================
Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:269
+    // Collect symbol information.
+    StringRef Name = Decl->getName();
+    StringRef USR = API.recordUSR(Decl);
----------------
I think we should be recording this in StringAllocator


================
Comment at: clang/test/ExtractAPI/objc_interface.m:17
 //--- input.h
- at protocol Protocol
- at end
+ at protocol Protocol;
 
----------------
Should this be done in the interfaces patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122511/new/

https://reviews.llvm.org/D122511



More information about the cfe-commits mailing list