[PATCH] D122524: [clang][AVR] Emit proper warnings

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 28 10:30:27 PDT 2022


MaskRay added a comment.

In D122524#3411872 <https://reviews.llvm.org/D122524#3411872>, @benshi001 wrote:

> In D122524#3410542 <https://reviews.llvm.org/D122524#3410542>, @MaskRay wrote:
>
>> I think it is excessive to add so many RUN lines. I do not understand much about AVR -mcpu. That said, I created D122553 <https://reviews.llvm.org/D122553> for what I think should be done for the `-c/-S/-fsyntax-only` condition. More tests would just be excessive.
>>
>> You may adjust the patch to do the rest cleanups/fixes.
>
> I have made some changes based on your https://reviews.llvm.org/D122553, it seems you have reverted. I suggest you recommit, since I have fixed the failures of lacking avr-gcc.

I did not specify --sysroot so the new tests failed on systems without avr-gcc. Relanded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122524/new/

https://reviews.llvm.org/D122524



More information about the cfe-commits mailing list