[PATCH] D122588: [RISCV] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 28 09:51:14 PDT 2022


MaskRay added a comment.

Thanks for the patch. I think it's correct, though I'd add `[test]` to indicate this patch is test only and therefore not change any code.

If the test no longer works on Windows, add `// UNSUPPORTED: system-windows`

Does riscv32-toolchain.c need a similar change? Please look around for related tests when fixing something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122588/new/

https://reviews.llvm.org/D122588



More information about the cfe-commits mailing list