[PATCH] D122592: [OpenMP] Fix library path missing when using OpenMP

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Another idea is to refactor `tools::addOpenMPRuntime` to use the full path of `libomp.so` or `libomp.a` instead of `-LXXX -lomp`.
The two ways have identical semantics when `libomp.so` has a `DT_SONAME` tag.

In the long term, perhaps libomp.so should be installed to the multiarch directory like `lib/x86_64-unknown-linux-gnu/libc++.so`.



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:741
     addOpenMPRuntimeSpecificRPath(TC, Args, CmdArgs);
+  addOpenMPRuntimeIncludePath(TC, Args, CmdArgs);
 
----------------
XXXIncludePath usually refers to the preprocessor include path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122592/new/

https://reviews.llvm.org/D122592