[PATCH] D121302: [HIP] Fix -fno-gpu-sanitize

Mon Mar 28 08:33:50 PDT 2022

yaxunl marked an inline comment as done.
yaxunl added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:165
   // Diagnose unsupported sanitizer options only once.
+  if (!Args.hasFlag(options::OPT_fgpu_sanitize, options::OPT_fno_gpu_sanitize))
+    return;
----------------
MaskRay wrote:
> Note: the third argument of hasFlag defaults to true before I removed it in 522712e2d241ea33575a9c7a60ad582634f04f0d. I suspect it might not be what you intended. 
The default value of OPT_fgpu_sanitize is intended to be true. Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121302/new/

https://reviews.llvm.org/D121302