[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

Amy Kwan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 28 06:19:01 PDT 2022


amyk added a comment.

Overall this change looks good to me, although I do have one question.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208
-  for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) {
-    if (E->getArg(i)->getType()->isArrayType())
-      Ops.push_back(EmitArrayToPointerDecay(E->getArg(i)).getPointer());
----------------
A question I have is do we not need to consider this/`EmitArrayToPointerDecay()` anymore? Was this not used for anything?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121637/new/

https://reviews.llvm.org/D121637



More information about the cfe-commits mailing list