[PATCH] D122495: [clang][extract-api] Use correct language info from inputs
Daniel Grumberg via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 28 04:23:33 PDT 2022
dang added inline comments.
================
Comment at: clang/include/clang/ExtractAPI/API.h:312
- /// Get the language options used to parse the APIs.
- const LangOptions &getLangOpts() const { return LangOpts; }
+ /// Get the language by the APIs.
+ Language getLanguage() const { return Lang; }
----------------
Nit: "by" isn't great here, maybe something along the lines of "Get the language the APIs are defined in."
================
Comment at: clang/include/clang/ExtractAPI/API.h:341
const llvm::Triple Target;
- const LangOptions LangOpts;
+ Language Lang;
----------------
`const` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122495/new/
https://reviews.llvm.org/D122495
More information about the cfe-commits
mailing list