[PATCH] D122553: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 27 22:30:25 PDT 2022


MaskRay created this revision.
MaskRay added reviewers: aykevl, benshi001.
Herald added subscribers: StephenFan, Jim, dylanmckay.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Many options (-fsyntax-only, -E, -S, etc) skip the link action phase which the
existing condition does not account for.

Since the code no longer specifies OPT_c, I think a single RUN line about -c
not leading to a warning is sufficient. Adding one for all of -E,
-fsyntax-only, -S would be excessive.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122553

Files:
  clang/lib/Driver/ToolChains/AVR.cpp
  clang/lib/Driver/ToolChains/AVR.h
  clang/test/Driver/avr-link-no-mcu-specified.c
  clang/test/Driver/avr-toolchain.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122553.418492.patch
Type: text/x-patch
Size: 8688 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220328/f00f9dc1/attachment.bin>


More information about the cfe-commits mailing list