[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 25 14:08:46 PDT 2022


jhuber6 updated this revision to Diff 418321.
jhuber6 added a comment.
Herald added a subscriber: jvesely.

Changing approach, we should optionally use internal linkage for the ctor
creation function since it's not correct to add the internal linkage attributes
and then make it external. Also remove it from the used global since it's not
needed anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122504/new/

https://reviews.llvm.org/D122504

Files:
  clang/lib/CodeGen/CGDeclCXX.cpp
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/lib/CodeGen/CodeGenModule.h
  clang/test/OpenMP/amdgcn_target_global_constructor.cpp
  clang/test/OpenMP/declare_target_codegen.cpp
  clang/test/OpenMP/nvptx_declare_target_var_ctor_dtor_codegen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122504.418321.patch
Type: text/x-patch
Size: 9594 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220325/4cf444e9/attachment.bin>


More information about the cfe-commits mailing list