[PATCH] D122499: [libTooling] Support TransformerResult<void> in consumer callbacks

Eric Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 25 13:37:35 PDT 2022


li.zhe.hua marked 2 inline comments as done.
li.zhe.hua added inline comments.


================
Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:126-128
+template <typename T>
+std::enable_if_t<std::is_void<T>::value, void>
+assertMetadataSet(const transformer::RewriteRuleWith<T> &) {}
----------------
ymandel wrote:
> Why won't a simple specialization work?
Yup, totally. Done.

I guess I see SFINAE so much more often these days I just reach for it first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122499/new/

https://reviews.llvm.org/D122499



More information about the cfe-commits mailing list