[PATCH] D122503: Remove dead code in driver parsing -gsimple-template-names= options
Paul Robinson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 25 13:23:40 PDT 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6aa039775891: Remove dead code in driver parsing -gsimple-template-names= options (authored by probinson).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122503/new/
https://reviews.llvm.org/D122503
Files:
clang/lib/Driver/ToolChains/Clang.cpp
Index: clang/lib/Driver/ToolChains/Clang.cpp
===================================================================
--- clang/lib/Driver/ToolChains/Clang.cpp
+++ clang/lib/Driver/ToolChains/Clang.cpp
@@ -4295,8 +4295,8 @@
? "-gpubnames"
: "-ggnu-pubnames");
const auto *SimpleTemplateNamesArg =
- Args.getLastArg(options::OPT_gsimple_template_names, options::OPT_gno_simple_template_names,
- options::OPT_gsimple_template_names_EQ);
+ Args.getLastArg(options::OPT_gsimple_template_names,
+ options::OPT_gno_simple_template_names);
bool ForwardTemplateParams = DebuggerTuning == llvm::DebuggerKind::SCE;
if (SimpleTemplateNamesArg &&
checkDebugInfoOption(SimpleTemplateNamesArg, Args, D, TC)) {
@@ -4304,17 +4304,6 @@
if (Opt.matches(options::OPT_gsimple_template_names)) {
ForwardTemplateParams = true;
CmdArgs.push_back("-gsimple-template-names=simple");
- } else if (Opt.matches(options::OPT_gsimple_template_names_EQ)) {
- ForwardTemplateParams = true;
- StringRef Value = SimpleTemplateNamesArg->getValue();
- if (Value == "simple") {
- CmdArgs.push_back("-gsimple-template-names=simple");
- } else if (Value == "mangled") {
- CmdArgs.push_back("-gsimple-template-names=mangled");
- } else {
- D.Diag(diag::err_drv_unsupported_option_argument)
- << Opt.getName() << SimpleTemplateNamesArg->getValue();
- }
}
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122503.418313.patch
Type: text/x-patch
Size: 1531 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220325/ddbf3b7a/attachment-0001.bin>
More information about the cfe-commits
mailing list