[clang-tools-extra] 9a3eeae - [clang-tidy] Fix the condition for building CTTestTidyModule

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 25 12:22:52 PDT 2022


Author: Martin Storsjö
Date: 2022-03-25T21:22:46+02:00
New Revision: 9a3eeae3218f0f8a082d8aabdf4f26e30a86170d

URL: https://github.com/llvm/llvm-project/commit/9a3eeae3218f0f8a082d8aabdf4f26e30a86170d
DIFF: https://github.com/llvm/llvm-project/commit/9a3eeae3218f0f8a082d8aabdf4f26e30a86170d.diff

LOG: [clang-tidy] Fix the condition for building CTTestTidyModule

This is the correct intended condition; the problematic case where
we don't want to try to build the plugin is "WIN32 AND LLVM_LINK_LLVM_DYLIB"
and thus the negation is "NOT WIN32 OR NOT LLVM_LINK_LLVM_DYLIB".

Differential Revision: https://reviews.llvm.org/D121687

Added: 
    

Modified: 
    clang-tools-extra/test/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt
index d64366cba2328..2cdf186081efc 100644
--- a/clang-tools-extra/test/CMakeLists.txt
+++ b/clang-tools-extra/test/CMakeLists.txt
@@ -73,7 +73,7 @@ foreach(dep ${LLVM_UTILS_DEPS})
 endforeach()
 
 if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
-  if (NOT WIN32 AND NOT LLVM_LINK_LLVM_DYLIB)
+  if (NOT WIN32 OR NOT LLVM_LINK_LLVM_DYLIB)
     llvm_add_library(
         CTTestTidyModule
         MODULE clang-tidy/CTTestTidyModule.cpp


        


More information about the cfe-commits mailing list