[PATCH] D122496: [C11] Correct the resulting type for an assignment expression
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 25 12:13:34 PDT 2022
cor3ntin accepted this revision.
cor3ntin added a comment.
Beside maybe a comment that could help understanding, I think this looks good!
================
Comment at: clang/lib/Sema/SemaExpr.cpp:13647
// operand.
- return (getLangOpts().CPlusPlus
- ? LHSType : LHSType.getUnqualifiedType());
+ return getLangOpts().CPlusPlus ? LHSType : LHSType.getAtomicUnqualifiedType();
}
----------------
I wonder if we want another comment here to make it extra clear that atomic should be stripped?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122496/new/
https://reviews.llvm.org/D122496
More information about the cfe-commits
mailing list