[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

Fri Mar 25 09:43:31 PDT 2022

aaron.ballman added a comment.

In D120185#3408258 <https://reviews.llvm.org/D120185#3408258>, @thakis wrote:

> That bot sets ENABLE_BACKTRACES=1.
>
> It seems to work for clang-cl (foo.cc contains `#pragma clang __debug parser_crash`):
>
>   >out\gn\bin\clang-cl /c foo.cc
>   PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
>   Stack dump:
>   0.      Program arguments: out\\gn\\bin\\clang-cl /c foo.cc
>   1.      foo.cc:1:23: at annotation token
>    #0 0x00007ff6653b7395 (C:\src\llvm-project\out\gn\bin\clang-cl.exe+0x3997395)
>
> I tried setting up a local cmake build, but cmake complains that it can't find py3 even though I have it installed. I also have today off, so I don't want to spend a lot of time debugging it.
>
> I'd suggest you land this with the test disabled on Win, and I'll debug it on Windows next week.

Okay, that works for me, this definitely sounds more involved than "bot configured wrong" but doesn't sound like "functionality is incorrect with the patch". Thanks for digging into this next week @thakis (and enjoy your day off!), and thanks for the discussion @njames93 while we figured out what to do next.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120185/new/

https://reviews.llvm.org/D120185