[PATCH] D120129: [NVPTX] Enhance vectorization of ld.param & st.param

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

Godbold seems to not have included this:

  $ cat test.cpp
  int main(){return 0;}
  $ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target -march=sm_80 test.cpp
  ... static bool llvm::isa_impl_cl<llvm::ConstantAsMetadata, const llvm::Metadata *>::doit(const From *) [To = llvm::ConstantAsMetadata, From = const llvm::Metadata *]: Assertion `Val && "isa<> used on a null pointer"' failed.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:4327
+  case GlobalValue::InternalLinkage:
+  case GlobalValue::PrivateLinkage: {
+    // Check that if a function has internal or private linkage
----------------
FWIW, `if (!F->hasLocalLinkage()) { return Align(ABITypeAlign); } <case code>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120129/new/

https://reviews.llvm.org/D120129