[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 25 07:08:17 PDT 2022


sammccall added a comment.

I don't actually know a great deal about matcher performance :-( I wish I did.
I think this is pretty much in line with how plenty of check matchers already work though, in particular unless(isInTemplateInstantiation()) is basically the same thing and is used in many places including this check.
So I wouldn't be particularly worried.

(Obviously from first principles you'd prefer to prune the subtree rather than match within it and then walk up the parent chain, but I don't think matchers supports this pattern well).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122078/new/

https://reviews.llvm.org/D122078



More information about the cfe-commits mailing list