[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

Fri Mar 25 04:51:53 PDT 2022

aaron.ballman added a comment.

In D120185#3406765 <https://reviews.llvm.org/D120185#3406765>, @njames93 wrote:

> In D120185#3405091 <https://reviews.llvm.org/D120185#3405091>, @aaron.ballman wrote:
>
>> @thakis -- is it possible your build bot is configured to disable generation of crash dumps?
>
> So with a lot of trial and error, it seems that on certain windows configurations, crash dumps just aren't being emitted.
> Best I can see so far is using clang to build the tests, results in ENABLE_BACKTRACES being enabled, but no crash dumps being emitted, causing the test failure.

>From looking at CMake, I don't see anything that actually tests if backtraces are enabled by the OS; we just trust the user told us something valid and set ENABLE_BACKTRACES accordingly. So I'd still like to hear from @thakis about his bot configuration.

> I did change the test to throw an assert instead of a TRAP instruction, and the assert message was captured but no crash dump was reported, so the test infrastructure has no issue there.

That's good at least.

> I feel like a stop gap may be to disable the test when clang is the host compiler and windows is the platform.

I wonder if "clang is the host compiler" is just happenstance though and this will cause us to pass @thakis' bots but not other testing situations (other downstreams, for example). So this may work as a stopgap, but if we can get to the bottom of the issue, I think it would be valuable. e.g., perhaps the better solution is for cmake to run a configure test to see if crash dumps are actually generated (or enabled, if there's a WMI query or something we can use), and if not, warn the user and don't define `ENABLE_BACKTRACES` in that case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120185/new/

https://reviews.llvm.org/D120185