[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

Gulfem Savrun Yeniceri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 24 17:08:52 PDT 2022


gulfem added a comment.

In D122336#3406843 <https://reviews.llvm.org/D122336#3406843>, @vsk wrote:

> So long as it doesn't change behavior expected by tapi on Darwin, I think it's OK. I doubt any other platforms are similarly affected.

I don't think it should impact TAPI because it relies on `needsRuntimeHookUnconditionally` function, which only returns false for `Fuchsia`.
So, this patch only affects the behavior of pulling in profile runtime for unused functions in `Fuchsia`.

  bool needsRuntimeHookUnconditionally(const Triple &TT) {
    // On Fuchsia, we only need runtime hook if any counters are present.
    if (TT.isOSFuchsia())
      return false;
  
    return true;
  }




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122336/new/

https://reviews.llvm.org/D122336



More information about the cfe-commits mailing list