[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.
Jennifer Yu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 24 13:47:13 PDT 2022
jyu2 added a comment.
In D122338#3405948 <https://reviews.llvm.org/D122338#3405948>, @ABataev wrote:
> LG
Thank you so much Alexey.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11988
if (isa<CXXThisExpr>(E)) {
Pos = ParamPositions[FD];
} else {
----------------
ABataev wrote:
> I would also recommend to replace all `operator []` calls to something that does not modify the map, like `find`.
How about adding assert? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122338/new/
https://reviews.llvm.org/D122338
More information about the cfe-commits
mailing list