[PATCH] D122424: [clang] [Driver] Add clang's relative `../lib` path only when in build tree

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 24 12:23:24 PDT 2022


MaskRay added a comment.

Is `addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths);` from D108286 <https://reviews.llvm.org/D108286> the issue?

If yes, I lean toward reverting D108286 <https://reviews.llvm.org/D108286> and possibly unsupporting `LIBCXX_LIBDIR_SUFFIX`.

The multilib style `lib32` `lib64` are more about glibc and GCC library search paths. llvm-project runtime libraries (including libc++) do not necessarily use that style.
In addition, we are shifting to multiarch style library names. There will just be no lib32/lib64.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122424/new/

https://reviews.llvm.org/D122424



More information about the cfe-commits mailing list