[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

Wang Yihan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 24 11:57:38 PDT 2022


yihanaa added a comment.

In D122248#3406117 <https://reviews.llvm.org/D122248#3406117>, @erichkeane wrote:

> LGTM!  Please give Aaron a few hours (perhaps until tomorrow?) to take 1 last look before committing.
>
> Also, if you lack commit rights and need someone to commit for you, please provide the name + email address you'd like it committed under.

Thanks @skan. I don’t have commit access, can you land this patch for me? (if there are no objections after a few days) Please use “wangyihan 1135831309 at qq.com” to commit the change.

In D122248#3406117 <https://reviews.llvm.org/D122248#3406117>, @erichkeane wrote:

> LGTM!  Please give Aaron a few hours (perhaps until tomorrow?) to take 1 last look before committing.
>
> Also, if you lack commit rights and need someone to commit for you, please provide the name + email address you'd like it committed under.

Thanks for your help and review @erichkeane, @aaron.ballman 😉 . I don’t have commit access, (if Aaron are no objections after a few hours) Please use “wangyihan 1135831309 at qq.com” to commit the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122248/new/

https://reviews.llvm.org/D122248



More information about the cfe-commits mailing list