[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

[Wang Yihan via Phabricator via cfe-commits]

yihanaa added a comment.

In D122248#3405166 <https://reviews.llvm.org/D122248#3405166>, @erichkeane wrote:

> In D122248#3405062 <https://reviews.llvm.org/D122248#3405062>, @aaron.ballman wrote:
>
>> In D122248#3403734 <https://reviews.llvm.org/D122248#3403734>, @yihanaa wrote:
>>
>>> What if we don't emit '=' for zero-width bitfield, like this:
>>>
>>>   struct Bar {
>>>   unsigned c : 1;
>>>   unsigned : 3;
>>>   unsigned : 0;
>>>   unsigned b;
>>>   };
>>>   
>>>   struct Bar {
>>>   unsigned int c : 1 = 0
>>>   unsigned int   : 3 = 0
>>>   unsigned int   : 0
>>>   unsigned int b = 0
>>>   }
>>>
>>> What do you all think?
>>
>> I like this idea best of all!
>
> Agreed!

@erichkeane @aaron.ballman


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122248/new/

https://reviews.llvm.org/D122248