[PATCH] D122315: [clangd] Retain main file fixes attached to diags from preamble

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 24 03:38:06 PDT 2022


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:68
     return true;
   // Fixes are always in the main file.
   if (!D.Fixes.empty())
----------------
sammccall wrote:
> update comment: Fixes are only added if the fix or diagnostics is in the main file.
as discussed offline, this is still the case and it isn't an `or` but an `and`, i.e. we preserve a fix if it's in the main file AND the primary diagnostic we'll attach it to is also inside the main file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122315/new/

https://reviews.llvm.org/D122315



More information about the cfe-commits mailing list