[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

Wed Mar 23 21:02:51 PDT 2022

zixuan-wu added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648
+#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER)                                   \
+  case CudaVersion::CUDA_##CUDA_VER:                                           \
+    PtxFeature = "+ptx" #PTX_VER;                                              \
----------------
jhuber6 wrote:
> zixuan-wu wrote:
> > It's same name as `CudaVersion` variable above, and it cause compile error. @jhuber6 
> > Maybe the error depends on host compiler version so that it does not report immediately.
> Fixed in rGd91223274145. Thanks for pointing that out, it worked fined locally.
Thank you for your quick action.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122089/new/

https://reviews.llvm.org/D122089