[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

[Xiang Zhang via Phabricator via cfe-commits]

xiangzhangllvm added inline comments.


================
Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:4
 // RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s   | FileCheck %s --check-prefix=FULL
+// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S -fcf-protection=branch -mibt-seal -flto %s | FileCheck %s --check-prefix=IBTSEAL
 
----------------
joaomoreira wrote:
> pengfei wrote:
> > Is `-flto` is required?
> Yes, we can only suppress ENDBR if we are sure the given function is not address taken in all other translation units.
Sorry, let me make sure here. what is the "translation units" here mean? Does it means another binary file (e.g. *.so , *.a)?
Using -flto seems here want more compile units (source files) to be one "translation units"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118052/new/

https://reviews.llvm.org/D118052