[PATCH] D121733: Clean pathnames in FileManager.

Wed Mar 23 16:36:50 PDT 2022

ppluzhnikov added a comment.

> Ignoring the ".." path components for the moment, is this patch good to go as is? It doesn't affect that behavior.

This patch still breaks Winx64 `clang-tidy/checkers/google-upgrade-googletest-case.cpp`.

The failure log here <https://buildkite.com/llvm-project/premerge-checks/builds/84379#f77f876b-fef6-4381-8c09-8be731b353c3> doesn't show //why// that test is failing, but I reproduced the failure on my home Windows 10 machine, and I am still digging into the failure reason.

One thing I noticed is this diff from running `clang-tidy`:

  < Suppressed 15 warnings (8 in non-user code, 7 with check filters).
  > Suppressed 38 warnings (31 in non-user code, 7 with check filters).

It appears that additional files are treated as "non-user code" after the patch.

However I don't think that's the root cause of the failure: when I added `--header-filter='.*'` I got:

  > Suppressed 7 warnings (7 with check filters).

but the test still failed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121733/new/

https://reviews.llvm.org/D121733