[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Other than this 1 thing, LGTM.  I DO find myself wondering how much of the CXXMethodDecl bit in the branch above is valid for 'naked' as well.  If it ISN'T we might consider  moving this loop AND that to EmitFunctionPrologue.



================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1200
+  if (!FD || !FD->hasAttr<NakedAttr>()) {
+    for (FunctionArgList::const_iterator i = Args.begin(), e = Args.end();
+         i != e; ++i) {
----------------
Since you're touching it... this looks like a 'range-for' loop :D 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122341/new/

https://reviews.llvm.org/D122341