[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

Wed Mar 23 11:24:12 PDT 2022

aaron.ballman added a comment.

In D120185#3403230 <https://reviews.llvm.org/D120185#3403230>, @njames93 wrote:

> In D120185#3397508 <https://reviews.llvm.org/D120185#3397508>, @thakis wrote:
>
>> Looks like this breaks tests on Windows: http://45.33.8.238/win/54785/step_7.txt
>>
>> Please take a look, and revert for now if takes a while to fix.
>
> I can't seem to reproduce the test failure on windows, are you opposed to relanding this with the test disabled on windows?

I'd like to understand what's happening better rather than land with a disabled test. Not getting the crash dump in some circumstances could either be specific to the machine configuration (which would be pretty tricky for us to solve in a unit test) or it could be something functionally wrong with the changes (though I would be surprised, tbh).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120185/new/

https://reviews.llvm.org/D120185