[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

[Abid via Phabricator via cfe-commits]

abidmalikwaterloo added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852
+    int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx);
+
+    EmitStmt(StaticWhenClauses[BestIdx]->getDirective());
----------------
ggeorgakoudis wrote:
> abidmalikwaterloo wrote:
> > This approach is valid for static conditions. How you are going to take care of multiple dynamic/runtime conditions?
> See GenerateCond that creates code for dynamic conditions. If the when clause has dynamically evaluated conditions it generates basicblocks and control logic.
Why get a score for static when clauses for the best clause? Is it according to OpenMP specification?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120573/new/

https://reviews.llvm.org/D120573