[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 23 07:36:01 PDT 2022


erichkeane added a comment.

In D122083#3402523 <https://reviews.llvm.org/D122083#3402523>, @royjacobson wrote:

> In D122083#3402445 <https://reviews.llvm.org/D122083#3402445>, @erichkeane wrote:
>
>> 1 more test I'd like to see that doesn't seem covered (ref to ptr),
>
> Added, good idea.
>
>> AND according to @aaron.ballman we need "Release Notes" for this.  Otherwise LGTM.  Do you have commit rights yet?
>
> Yeah, I got commit rights :)
> This should go into "Bug Fixes" section in `clang/docs/ReleaseNotes.rst`, right? Or "C++20 Feature Support"?

I'd suggest 'bug fixes'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122083/new/

https://reviews.llvm.org/D122083



More information about the cfe-commits mailing list