[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin updated this revision to Diff 417586.
cor3ntin added a comment.

- Fix test
- Add a comment explaining why we do not use CheckLiteralType

@aaron,ballman I completely missed that...!

However, CheckLiteralType does a bunch of tests that we do not need
to diagnose *why* a type is not literal, which we do not care about here.

I tried to play around with the code and trying to use CheckLiteralType, or to modify
it for this scenario does not appear to me an improvenent, so I rather keep the change as is.

I also fixed the fail test, i think i accidentally removed a line from the test file...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122249/new/

https://reviews.llvm.org/D122249

Files:
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p3-2b.cpp
  clang/test/SemaCXX/constant-expression-cxx2b.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122249.417586.patch
Type: text/x-patch
Size: 5689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220323/963aabf8/attachment.bin>