[PATCH] D122083: [Concepts] Fix placeholder constraints when references are involved

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 23 05:54:22 PDT 2022


erichkeane added a comment.

Can you add some tests for the OTHER forms of 'auto' as well?  We have `decltype(auto)` and `auto_type`, and I want to make sure whatever we do with those 'looks right'.



================
Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:4773
+  QualType MaybeAuto = Type.getType().getNonReferenceType();
+  while (MaybeAuto->isPointerType()) {
+    MaybeAuto = MaybeAuto->getPointeeType();
----------------
We don't do curley braces on single-line blocks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122083/new/

https://reviews.llvm.org/D122083



More information about the cfe-commits mailing list