[PATCH] D118493: Set rpath on openmp executables

Wed Mar 23 03:15:30 PDT 2022

JonChesterfield added a comment.

In D118493#3401448 <https://reviews.llvm.org/D118493#3401448>, @tstellar wrote:

> The rule that is broken is "standard RPATHs" Fedora installs libomp to /usr/lib64.
>
> ...
>
>   I think what we'll do in Fedora is just add -fno-openmp-implicit-rpath to the default CFLAGS so we can get the old behavior for official RPMs.

Sounds good to me. I especially like the rapid unblocking.

Slightly longer term, we might want to adjust clang to notice when the rpath it is about to set coincides with a system directory. The purpose of this patch is to have clang -fopenmp -o a.out && ./a.out work without setting environment variables, but where the openmp libs in question are on the system search path the rpath is not necessary.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118493/new/

https://reviews.llvm.org/D118493