[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

[David Spickett via Phabricator via cfe-commits]

DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

This LGTM with the test only requiring Arm.

Please mention in the commit that it is possible to ignore this warning in system headers, but we chose not to because of potential false positives.



================
Comment at: clang/test/Sema/arm-neon-decl-after-stmt.c:3
+// RUN:  -Wdeclaration-after-statement -fsyntax-only -verify %s
+// REQUIRES: aarch64-registered-target || arm-registered-target
+// https://github.com/llvm/llvm-project/issues/54062
----------------
DavidSpickett wrote:
> Does `armebv7` work when you only have aarch64?
> 
> It probably does just by virtue of aarch64 not knowing what v7 is and defaulting to v8 but double check what happens there.
> 
> If the emitter is used for both arm and aarch64 then testing one would be acceptable. Since you can't really do an if has arm do this else in a lit test like this.
Maybe this is phabricator showing me the diff strangely, but it seems like you removed the aarch64 requirement from a different test instead of this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122189/new/

https://reviews.llvm.org/D122189