[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 22:05:18 PDT 2022


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Thanks! I agree that this assertion doesn't make much sense. Judging by the name, the function should be able to handle all symbols.



================
Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:61
+        // to canonicalize "a - b" and "b - a", which would allow us to treat "a
+        // != b" and "b != a" the same.
+
----------------
The new line break in the middle of `a != b` doesn't make much sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122277/new/

https://reviews.llvm.org/D122277



More information about the cfe-commits mailing list