[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 22:03:01 PDT 2022


NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:41
 //
-// The following standard C functions are currently supported:
-//
----------------
This comment has been out of date for years and I don't think it makes sense to have it in the first place.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1215-1217
           // The locale-specific range.
           // No post-condition. We are completely unaware of
           // locale-specific return values.
----------------
I'm not adding notes to these ranges because these days I think they were a mistake. A three-way (sometimes four-way) state split is pretty hard to justify. It's much safer to drop the case and stick to the two ASCII cases.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122285/new/

https://reviews.llvm.org/D122285



More information about the cfe-commits mailing list