[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 22 20:57:37 PDT 2022
MaskRay added a comment.
Herald added a subscriber: StephenFan.
This may need a test in `clang/test/Misc/cc1as-*`.
Can you add to the description what the `clang -cc1as` usage looks like?
================
Comment at: clang/tools/driver/cc1as_main.cpp:217
+ llvm::Triple TVT(A->getValue());
+ Opts.DarwinTargetVariantTriple = TVT;
+ }
----------------
================
Comment at: clang/tools/driver/cc1as_main.cpp:419
+ if (Opts.DarwinTargetVariantTriple) {
+ MOFI->setDarwinTargetVariantTriple(*Opts.DarwinTargetVariantTriple);
+ }
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121868/new/
https://reviews.llvm.org/D121868
More information about the cfe-commits
mailing list