[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 11:10:56 PDT 2022


steakhal marked an inline comment as done.
steakhal added a comment.

Now it should be much smaller.
Sorry for not doing this in the first place.



================
Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:90-91
+
+  return (llvm::Twine("https://clang.llvm.org/docs/analyzer/checkers.html#") +
+          CheckerFullName)
       .str();
----------------
martong wrote:
> > This patch will ensure that the doc urls produced by tablegen for the ClangSA, will use the new url. Nothing else will be changed.
> 
> If that was the case then we'd need only this hunk of change plus the test file. Perhaps it would make sense to either split this to more patches
> - Adding `Sep`
> - Handling missing documentation
> - new url
> Or please change the description of the patch about these changes.
Thanks, done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121387/new/

https://reviews.llvm.org/D121387



More information about the cfe-commits mailing list