[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.
Nathan Sidwell via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 22 10:28:22 PDT 2022
urnathan accepted this revision.
urnathan added a comment.
This revision is now accepted and ready to land.
looks resonable, 1 nit.
================
Comment at: clang/lib/Driver/Driver.cpp:2453
// Disambiguate headers that are meant to be header units from those
- // intended to be PCH.
- if (Ty == types::TY_CXXHeader && hasHeaderMode())
+ // intended to be PCH. Avoid missing '.h' cases that are counted as
+ // C headers by default - we know we are in C++ mode and we do not
----------------
extra whitespace 'are[spc][spc]counted'
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121590/new/
https://reviews.llvm.org/D121590
More information about the cfe-commits
mailing list