[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

Tue Mar 22 10:15:08 PDT 2022

adamcz added a comment.

In D121824#3399208 <https://reviews.llvm.org/D121824#3399208>, @sammccall wrote:

> I reduced something very similar recently as https://github.com/clangd/clangd/issues/1073
>
> This patch does not fix it, but looks closely related, want to take a look?

Very similar. My original fix would've fixed that too. I'm reverting this change to that version and adding this as a test.

Based on my conversation with Sam I'm also reverting the mark-ref-VarDecl-as-invalid-when-on-invalid-init, as I no longer believe this is appropriate. The idea is that, init or not, we know the type of VarDecl so it's not invalid (unless it's auto or something).

PTAL

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121824/new/

https://reviews.llvm.org/D121824