[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 22 08:49:31 PDT 2022


MyDeveloperDay added inline comments.


================
Comment at: clang/docs/tools/dump_format_help.py:29
+def get_help_output():
+    args = ["clang-format", "--help"]
+    cmd = subprocess.Popen(args, stdout=subprocess.PIPE,
----------------
curdeius wrote:
> sstwcw wrote:
> > You intentionally did not write `build/bin/clang-format` to accommodate people who build in other directories, right? Sorry this comment is late.
> I wanted to be coherent with the `generate_formatted_state.py` script that calls `clang-format` from PATH as well.
> A user that builds elsewhere needs to set PATH when executing the script to use clang-format of their choice.
you definitely can't assume "build", for me my build directory is build_ninja




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121916/new/

https://reviews.llvm.org/D121916



More information about the cfe-commits mailing list